Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yourgov: Edit steps from a review page via sub page #1925

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ChrisLaneAU
Copy link
Contributor

@ChrisLaneAU ChrisLaneAU commented Jan 13, 2025

Implements a sub-step from the Review and Submit page for editing steps. Handling navigating to sub-pages from sub-pages is parked until further investigation can be done so it's currently rendering a warning modal.

View preview

Checklist

Preflight

  • Prefix the PR title with the slug of the package or component - e.g. accordion: Updated padding or docs: Updated header links
  • Describe the changes clearly in the PR description
  • Read and check your code before tagging someone for review
  • Create a changeset file by running yarn changeset. Learn more about change management.

Testing

  • Manually test component in various modern browsers at various sizes (use Browserstack)
  • Manually test component in various devices (phone, tablet, desktop)
  • Manually test component using a keyboard
  • Manually test component using a screen reader
  • Manually tested in dark mode
  • Component meets Web Content Accessibility Guidelines (WCAG) 2.1 standards
  • Add any necessary unit tests (HTML validation, snapshots etc)
  • Run yarn test to ensure tests are passing. If required, run yarn test -u to update any generated snapshots.

Documentation

  • Create or update documentation on the website
  • Create or update stories for Storybook
  • Create or update stories for Playroom snippets

Creating new component

  • Add documentation for the component (docs/overview.mdx and docs/code.mdx at a minimum)
  • Preconstruct entrypoint has been created (run yarn in the root of the repo to do this)
  • Changeset file includes a minor
  • Export components for docs site and Playroom (docs/components/designSystemComponents.tsx)
  • Add component to Kitchen Sink (.storybook/stories/KitchenSink.tsx)
  • Add snippets to Playroom (docs/playroom/snippets.ts)
  • Add figmaGalleryNodeId to Docs (docs/components/pictograms/index.tsx)
  • Add pictogram to Docs (docs/components/pictograms/index.tsx)

@ChrisLaneAU ChrisLaneAU self-assigned this Jan 13, 2025
Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 06cbbb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ag.ds-next/yourgov Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 13, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://agriculturegovau.github.io/agds-next/pr-preview/pr-1925/

Built to branch gh-pages at 2025-01-14 02:26 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ChrisLaneAU ChrisLaneAU requested a review from stowball January 15, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant