Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading: Announce fullscreen LoadingBlanket assertively #1916

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

stowball
Copy link
Contributor

@stowball stowball commented Dec 17, 2024

We discovered that the fullscreen LoadingBlanket wasn't being announced in JAWS and NVDA in yourgov and other implementations. Making it role="alert" fixes it in these and makes no difference to the others.

View preview

Checklist

Preflight

  • Prefix the PR title with the slug of the package or component - e.g. accordion: Updated padding or docs: Updated header links
  • Describe the changes clearly in the PR description
  • Read and check your code before tagging someone for review
  • Create a changeset file by running yarn changeset. Learn more about change management.

Testing

  • Manually test component in various modern browsers at various sizes (use Browserstack)
  • Manually test component in various devices (phone, tablet, desktop)
  • Manually test component using a keyboard
  • Manually test component using a screen reader
  • Manually tested in dark mode
  • Component meets Web Content Accessibility Guidelines (WCAG) 2.1 standards
  • Add any necessary unit tests (HTML validation, snapshots etc)
  • Run yarn test to ensure tests are passing. If required, run yarn test -u to update any generated snapshots.

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 2097cee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ag.ds-next/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stowball stowball requested a review from ChrisLaneAU December 17, 2024 05:38
Copy link
Contributor

github-actions bot commented Dec 17, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2025-01-05 22:41 UTC

@stowball stowball merged commit 55637c9 into develop Jan 5, 2025
8 checks passed
@stowball stowball deleted the loading-blanket-announcement branch January 5, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants