Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hover popup to centroids and project features #43

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

steveoh
Copy link
Member

@steveoh steveoh commented Dec 10, 2024

refs #16

@steveoh steveoh requested a review from stdavis December 10, 2024 02:26
@steveoh steveoh enabled auto-merge (squash) December 10, 2024 02:26
Copy link

github-actions bot commented Dec 10, 2024

Visit the preview URL for this PR (updated for commit 3ed98c7):
Firebase Preview: https://ut-dts-agrc-wri-dev--feat-hover-popup-w0jsz0n5.web.app
(expires "2024-12-24T23:46:27.722461037Z" )

stdavis
stdavis previously approved these changes Dec 10, 2024
Copy link
Member

@stdavis stdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I like the idea of using the DOM api's for moving the tooltip around rather than rerendering the component.

I also had the thought today that perhaps a hover popup could be configured as part of the feature service? Or maybe that's just an AGOL thing. Either way, I think that this solution is great.

src/components/MapContainer.tsx Outdated Show resolved Hide resolved
src/mapLayers.ts Show resolved Hide resolved
@steveoh
Copy link
Member Author

steveoh commented Dec 10, 2024

I also had the thought today that perhaps a hover popup could be configured as part of the feature service.

I wasn't able to find this. Is this a thing?

@stdavis
Copy link
Member

stdavis commented Dec 11, 2024

I wasn't able to find this. Is this a thing?

I'm not sure. Maybe it's an AGOL thing, not stand-alone server.

@steveoh steveoh merged commit ad6ee8f into main Dec 11, 2024
7 checks passed
@steveoh steveoh deleted the feat/hover-popup branch December 11, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants