Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(toggle-button): introduce a toggle button #380

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Conversation

steveoh
Copy link
Member

@steveoh steveoh commented Dec 4, 2024

A formatting fix is wrapped up in here also

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Visit the preview URL for this PR (updated for commit 07ba36c):
Firebase Preview: https://ut-dts-agrc-kitchen-sink-dev--feat-toggle-button-qb8qc5xh.web.app
(expires "2024-12-19T03:32:41.674018144Z" )

['a', undefined].join(',') => a,
Copy link
Member

@stdavis stdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me other than the performance seems a bit off in the preview. The first time that I click a button, it takes a half second to change. Not sure if it's just me. I'm not too worried about it.

@steveoh
Copy link
Member Author

steveoh commented Dec 5, 2024

We looked at this together and the issue may just be in storybook. We'll keep an eye on it though.

@steveoh steveoh merged commit 6ef5ea5 into main Dec 5, 2024
6 checks passed
@steveoh steveoh deleted the feat/toggle-button branch December 5, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants