Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField: Allow for passing props to Input #396

Closed
stdavis opened this issue Dec 18, 2024 · 3 comments · Fixed by #398
Closed

TextField: Allow for passing props to Input #396

stdavis opened this issue Dec 18, 2024 · 3 comments · Fixed by #398
Labels
design-system enhancement New feature or request

Comments

@stdavis
Copy link
Member

stdavis commented Dec 18, 2024

I would like to set some HTML props of the input element inside of the TextField component such as spellCheck={false}. I couldn't figure out a way to do this since no props are passed from TextField down to the Input component within it. Maybe adding a prop called inputProps would work?

@steveoh
Copy link
Member

steveoh commented Dec 18, 2024

Try linking that branch and see how it works. What's the reason for disabling spellcheck? Is it personal preference or the type of data you are keeping within it.

@stdavis
Copy link
Member Author

stdavis commented Dec 18, 2024

What's the reason for disabling spellcheck?

I'm working on the address verification. When typing in addresses, there are lots of words that spellcheck doesn't like (e.g. "Holladay"). I just thought that it was annoying and wanted to turn it off. But I could also see wanting to add other props.

@steveoh
Copy link
Member

steveoh commented Dec 18, 2024

I do like the idea of being able to forward props. some folks might like spellcheck but i'm indifferent with whatever you choose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-system enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants