Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGID Index Validation Issues #2760

Closed
github-actions bot opened this issue May 22, 2024 · 19 comments
Closed

SGID Index Validation Issues #2760

github-actions bot opened this issue May 22, 2024 · 19 comments
Labels
sgid index validation only used by automation

Comments

@github-actions
Copy link
Contributor

Validation errors have been detected in the SGID Index. This issue will be used to track the resolution of these issues.

GitHub Actions should post a comment with the details shortly...

To rerun the validation script, add a new comment that starts with the following text: /validate-sgid-index.

@github-actions github-actions bot added the sgid index validation only used by automation label May 22, 2024
Copy link
Contributor Author

github-actions bot commented May 22, 2024

SGID Index Validation

2024-07-31 19:14:43

Script Output

using ci credentials
loading spreadsheet
building duplicate lookups
checking 531 rows

total errors: 5
updated 8 rows

Validation Errors

displayName id Error
Pony Express 1f62a035-edf1-436a-869b-6c280fe5253c No "productPage" or "itemId"
SMS Safety Index 8d8c0e70-9989-4527-af42-49d57f86a7f7 No "productPage" or "itemId"
SMS Severe Crashes Per Mile d7f54d25-8781-4162-8666-690b3eb6688a No "productPage" or "itemId"
State Boundary Snap Points 6c80a6ba-8202-411f-b5f0-abb9905ecef3 No "productPage" or "itemId"
Watershed Restoration Initiative Treatment Areas bfa1fa62-19b9-4315-aad1-54a23cb7968e No "productPage" or "itemId"

@stdavis

This comment was marked as outdated.

1 similar comment
@stdavis

This comment has been minimized.

@steveoh

This comment was marked as outdated.

@jacobdadams
Copy link
Member

For the NFHL one, I'm not sure why it's giving a 404 error. That is the right itemID for the flood hazard area layer. Is it because it's hosted in DEM's org? https://utah-em.maps.arcgis.com/home/item.html?id=b2c606f13a4c4a59b3c253647883833f

@stdavis
Copy link
Member

stdavis commented Jun 26, 2024

@jacobdadams Do you know if that item is shared a hub? This is the request that the validation script is attempting to make:

https://opendata.arcgis.com/api/v3/datasets/833d52f3-ad52-499f-a95e-64fcdf84a956_49

It returns 403 - forbidden.

@jacobdadams
Copy link
Member

It does not look like it, no. While they have a hub site, they don't really have an open data portal in it. I wonder if we should explore having them share it to one of our SGID groups so that it shows up in ours?

@stdavis
Copy link
Member

stdavis commented Jun 26, 2024

Hub does seem to be a requirement for the validation script. I'm not sure if that was intended or not. We do seem to default to sharing links to hub over AGOL. Perhaps because it is more targeted to a more universal audience.

@jacobdadams
Copy link
Member

So is that in effect saying that if the SGID index references an AGOL item, it needs to be shared via hub?

@stdavis
Copy link
Member

stdavis commented Jun 26, 2024

So is that in effect saying that if the SGID index references an AGOL item, it needs to be shared via hub?

That's the way that the validation script is written. I don't remember if that is an official decision that has been made. @steveoh ?

@steveoh
Copy link
Member

steveoh commented Jun 26, 2024

it needs to be shared via hub?

This is most likely a product of our testing data. Since most of the items are shared via Hub, that was the route we took for validation. I guess we'll need to rethink this a bit.

The sgid index sheet is designed around hub with the schema and this isn't a hub item. We could add the AGOL item urls to the product URL and skip the hub stuff... I'd have to take a minute to think this through a bit more as I'm not sure all of the side effects.

@gregbunce
Copy link
Contributor

after reaching out to udot, i was able to update/remove the records they steward.

@steveoh or @stdavis can we run the validation again to see where we stand?

@steveoh

This comment was marked as resolved.

@gregbunce
Copy link
Contributor

gregbunce commented Jul 1, 2024

/validate-sgid-index

@steveoh

This comment was marked as resolved.

@gregbunce
Copy link
Contributor

hey, @mhchou when you get time, can you look at the UHP Dispatch validation error? thanks!

@stdavis

This comment was marked as outdated.

@steveoh
Copy link
Member

steveoh commented Jul 22, 2024

I've learned that you can edit an existing comment that starts with that trigger to start the validation without the need to create another comment.

steveoh added a commit that referenced this issue Jul 22, 2024
@steveoh
Copy link
Member

steveoh commented Aug 1, 2024

New month new issue 😁

@steveoh steveoh closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sgid index validation only used by automation
Projects
None yet
Development

No branches or pull requests

4 participants