Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] What's Here doesn't work with non-private land when Land Ownership is on #475

Closed
2 of 8 tasks
jacobdadams opened this issue Sep 9, 2024 · 2 comments · Fixed by #481
Closed
2 of 8 tasks
Labels

Comments

@jacobdadams
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I was playing around on Atlas and it looks like the "What's Here" feature doesn't work on non-private land when you have the Land Ownership layer turned on. With that layer off, I can click somewhere in a National Forest, or State Park, or similar and get info. However, when I turn Land Ownership on, it doesn't seem to register that I've clicked. It's almost like that layer is "intercepting" the click (maybe because it's the topmost layer?)

Browsers

  • Chrome
  • Safari
  • Firefox
  • Brave
  • Microsoft Edge
  • Internet Explorer
  • Other

Reproduction steps

  1. Turn on Land Ownership
  2. Click on the Mt Timp summit
  3. Turn off Land Ownership
  4. Click on the Mt timp summit

Developer console logs

Console log doesn't log any requests when clicking on a location covered by the Land Ownership layer.

Additional information

No response

@steveoh
Copy link
Member

steveoh commented Sep 9, 2024

Good catch. The hit test is running on the vector layer and expecting a popup to show up instead of doing the identify. This logic was intended to not identify when selecting a geocode or sherlock match graphic.

steveoh added a commit that referenced this issue Oct 2, 2024
steveoh added a commit that referenced this issue Oct 2, 2024
@steveoh steveoh closed this as completed in 23e4dbf Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

🥳 This issue is included in v5.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants