allow non-Symbol object properties on RSAA #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the proposed change regarding Issue #188.
Dev setup was easier than expected and worked just as described! 👍Let me know if I need to change anything for convention, or add/edit additional tests or documentation.
This change only removes this requirement from the
validateRSAA
method, and from the documentation. It doesn't seem as if anything else in the codebase requires the old behavior.This is still a breaking change though and does effect the existing RSAA specification, so probably best grouped into a future
major
(v3+) release after ppl have time to discuss in this PR (and if we still want to make this change) :)