Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve and align Makefiles #50

Open
wants to merge 7 commits into
base: Agoric
Choose a base branch
from

Conversation

gibson042
Copy link

@gibson042 gibson042 commented Jul 8, 2024

Can be reviewed commit-by-commit or all at once.

Future work may merge the four Makefiles into a pair or even just one file.

@gibson042 gibson042 requested a review from mhofman July 8, 2024 20:59
@mhofman
Copy link
Contributor

mhofman commented Jul 8, 2024

FYI I have been avoiding making too many changes to the makefiles to avoid conflicts with the fork @phoddie maintains, or diverging from the Makefiles of the Moddable repo itself, changes to which we usually need to reflect here.

@gibson042
Copy link
Author

FYI I have been avoiding making too many changes to the makefiles to avoid conflicts with the fork @phoddie maintains

That seems to be the only fork, so I think we can reconcile.

or diverging from the Makefiles of the Moddable repo itself, changes to which we usually need to reflect here.

Can you elaborate? If we're considering other files to be essentially upstream, I'd like to document that here.

@gibson042 gibson042 requested a review from phoddie July 8, 2024 21:42
@mhofman
Copy link
Contributor

mhofman commented Jul 8, 2024

Can you elaborate? If we're considering other files to be essentially upstream, I'd like to document that here.

My understanding is that these makefiles were started as copies of https://github.com/Moddable-OpenSource/moddable/tree/public/xs/makefiles (or more precisely their ancestors). When upgrading XS version it often involves replicating changes made to these makefiles (amongst other things)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants