-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Improve and align Makefiles #50
base: Agoric
Are you sure you want to change the base?
Conversation
…under a MODDABLE dependency This aligns with the `xsnap-worker` build process.
This aligns with the `xsnap-worker` build process.
FYI I have been avoiding making too many changes to the makefiles to avoid conflicts with the fork @phoddie maintains, or diverging from the Makefiles of the Moddable repo itself, changes to which we usually need to reflect here. |
That seems to be the only fork, so I think we can reconcile.
Can you elaborate? If we're considering other files to be essentially upstream, I'd like to document that here. |
My understanding is that these makefiles were started as copies of https://github.com/Moddable-OpenSource/moddable/tree/public/xs/makefiles (or more precisely their ancestors). When upgrading XS version it often involves replicating changes made to these makefiles (amongst other things) |
Can be reviewed commit-by-commit or all at once.
Future work may merge the four Makefiles into a pair or even just one file.