Restore snapshot in existing worker #48
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
force-pushed
the
mhofman/load-snapshot-2
branch
from
3fbabc8 to
9f6616b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the original load snapshot command I explored last year, with
fxUseSnapshotfrom #44 to create a new "restore" command that reads a snapshot from a file or std pipe.I'm actually not sure if the snapshot restored like this must be the same as the one that was previously written out. Regardless, this may be an option to reload the snapshot in the same process. (It may be interesting if this can be another snapshot entirely as a sort of worker process pool)
Since agoric-sdk currently creates a new worker process and streams the snapshot to it as it's being created, it's likely less performant to use the same process.
While there are 3 commits in this PR, it's only for historical purposes and meant to be squashed.