Adding Keplr Intereactions for Wallet and Handle an Edge Case #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabi-siddique
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -361,7 +385,7 @@ | |||
| retries = 0; | |||
| await page.bringToFront(); | |||
| await module.exports.waitUntilStable(page); | |||
| return page; | |||
| return page | |||
Check notice
Code scanning / CodeQL
Semicolon insertion Note
* feature: adding keplr interaction for creating an account using private key * feature: keplr interaction for importing an existing wallet and creating a new wallet * fix: fixed implementation of waitAndClickByText to perform exact matching --------- Co-authored-by: Fraz Arshad <[email protected]>
…ady-connected-to-wallet' into rs-handling-popup-case-when-already-connected-to-wallet
frazarshad
reviewed
Mar 1, 2024
Comment on lines
+448
to
+454
| cy.contains('agoric1p2aqakv3ulz4qfy2nut86j9gx0dx0yw09h96md'); | ||
| cy.contains('Make an Offer').click(); | ||
| return cy.confirmTransaction().then(taskCompleted => { | ||
| expect(taskCompleted).to.be.true; | ||
| }); | ||
| }); |
There was a problem hiding this comment.
these functions should not contain logic related to our offer up dapp since these will be part of the synpress framework and will be exposed to all users
| @@ -361,7 +385,7 @@ | |||
| retries = 0; | |||
| await page.bringToFront(); | |||
| await module.exports.waitUntilStable(page); | |||
| return page; | |||
| return page | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds Kepler Interactions for:
And it handles an edge case illustrated below:
Scenario:
Test Case 1: The user has to connect with the wallet. The user clicks the connect wallet button. Popups show and the user approves the connection.
Test Case 2: The user is performing some operation. The user needs to connect to the wallet. The user clicks the connect wallet button. No popup shows ==> The user was already connected to the wallet as this happened in the first test case.
The PR addresses this edge case and handles scenarios where the user is already connected to the wallet.