Fix for switching between keplr windows with same url (#27)

* fix: checking added for window instance * test: test added for edge case
agoric-labs · Mar 13, 2024 · 96b238b · 96b238b
1 parent 3ae40a6
commit 96b238b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/commands/playwright-keplr.js b/commands/playwright-keplr.js
@@ -340,7 +340,8 @@ module.exports = {
       if (
         page
           .url()
-          .includes(`chrome-extension://${keplrExtensionData.id}/popup.html`)
+          .includes(`chrome-extension://${keplrExtensionData.id}/popup.html`) &&
+        page !== keplrWindow
       ) {
         keplrNotificationWindow = page;
         retries = 0;

diff --git a/tests/e2e/specs/keplr/keplr-spec.js b/tests/e2e/specs/keplr/keplr-spec.js
@@ -103,6 +103,16 @@ describe('Keplr', () => {
         expect(tokenValue).to.equal(331);
       });
     });
+    it(`should differntiate between keplrWindow and keplrNotificationWindow when they have the same URL`, () => {
+      cy.getTokenAmount('ATOM').then(tokenValue => {
+        expect(tokenValue).to.equal(0);
+      });
+
+      cy.contains('Make an Offer').click();
+      cy.confirmTransaction().then(taskCompleted => {
+        expect(taskCompleted).to.be.true;
+      });
+    });
     it(`should disconnect the wallet from all the connected DAPPs`, () => {
       cy.disconnectWalletFromDapp().then(taskCompleted => {
         expect(taskCompleted).to.be.true;