build: versions from agoric-upgrade-13 for normal bundle size #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
reviewed
Dec 29, 2023
Comment on lines
95
to
96
| "@babel/code-frame": "7.18.6", | ||
| "@babel/highlight": "7.22.5" |
There was a problem hiding this comment.
FYI you should be able to remove this, and upgrade the babel dependencies to their latest now that a fix has been release upstream.
There was a problem hiding this comment.
will try that out after merging this version, which is tested
based on Agoric/agoric-sdk#8274 (including crabble stuff) plus flailing - hoist lint devDependencies from contract to top - add lint / lint-fix scripts in contract
to avoid a huge bundle Agoric/agoric-sdk#8621 (comment)
dtribble
approved these changes
Dec 29, 2023
contract/Makefile
Outdated
| @@ -84,6 +84,9 @@ install-bundles: bundles/bundle-list | |||
|
|
|||
| build-proposal: bundles/bundle-list | |||
|
|
|||
| agoric-install: | |||
There was a problem hiding this comment.
This turned out to not be necessary
dckc
changed the title
This was referenced Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4