Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: cherry-pick commits for v0.46.16-alpha.agoric.2.4 #420

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

gibson042
Copy link

@gibson042 gibson042 commented Apr 19, 2024

Description

Cherry-pick #419 and update CHANGELOG-Agoric.md.

Refs: Agoric/agoric-sdk#9224


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

JimLarson and others added 2 commits April 19, 2024 11:26
Also more documentation for TOML template.

(cherry picked from commit 820bc69)
@gibson042 gibson042 requested a review from JimLarson April 19, 2024 15:33
@gibson042 gibson042 changed the title build: Cherry pick commits for patch release build: cherry-pick commits for v0.46.16-alpha.agoric.2.4 Apr 19, 2024
@JimLarson
Copy link

Failing lint check expected - fails in upstream at this point.

@JimLarson JimLarson merged commit ea82623 into Agoric-v0.46.16.2.x Apr 19, 2024
38 of 39 checks passed
@JimLarson JimLarson deleted the gibson-agoric-upgrade-15-cherry-picks branch April 19, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants