Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick and update docs for v0.46.16-alpha.agoric.2.3 #417

Merged
merged 4 commits into from
Apr 18, 2024
Merged

chore: cherry-pick and update docs for v0.46.16-alpha.agoric.2.3 #417

merged 4 commits into from
Apr 18, 2024

Conversation

JimLarson
Copy link

@JimLarson JimLarson commented Apr 18, 2024 •
edited
Loading

Description

Cherry-pick #415 and #416.

Update changelog.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

JimLarson and others added 4 commits April 17, 2024 19:44
@JimLarson
fix: avoid duplicates in event history
e921419 
Also add tests and documentation.
@JimLarson
refactor: readability and start stamping our fork changes
1f5a3a3
@JimLarson
feat: abci client type now an explicit config setting (#416)
7e3acd0 
* feat: abci client type now an explicit config setting

Setting the flag still works and takes precedence.

* docs: changelog entry

* refactor: common location for valid abci client types and default

* refactor: actually use the defined default value
@JimLarson
docs: prepare changelog for next release
a9e7504
@JimLarson JimLarson added enhancement New feature or request agoric-cosmos Agoric tags for cosmos labels Apr 18, 2024
@JimLarson JimLarson requested review from mhofman and gibson042 April 18, 2024 02:58
@JimLarson JimLarson self-assigned this Apr 18, 2024
gibson042
gibson042 approved these changes Apr 18, 2024
View reviewed changes
Copy link

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimLarson JimLarson merged commit 573fd3b into Agoric-v0.46.16.2.x Apr 18, 2024
38 of 39 checks passed
@JimLarson JimLarson deleted the jim-u15-cherry branch April 18, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibson042 gibson042 gibson042 approved these changes

@mhofman mhofman Awaiting requested review from mhofman

Assignees

@JimLarson JimLarson

Labels
agoric-cosmos Agoric tags for cosmos enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimLarson @gibson042