Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable sims workflow #383

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix: disable sims workflow #383

merged 1 commit into from
Feb 21, 2024

Conversation

JimLarson
Copy link

Description

Closes: Agoric/agoric-sdk#8890

The sims tests, in particular test-sim-after-import, sometimes take over 12 minutes to run and are cancelled, so we're disabling for now.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@JimLarson JimLarson added the agoric-cosmos Agoric tags for cosmos label Feb 20, 2024
@JimLarson JimLarson requested a review from michaelfig February 20, 2024 23:07
@JimLarson JimLarson self-assigned this Feb 20, 2024
@JimLarson JimLarson changed the title Disable sims workflow fix: disable sims workflow Feb 21, 2024
@JimLarson JimLarson merged commit 0d5eab2 into Agoric Feb 21, 2024
26 of 28 checks passed
@JimLarson JimLarson deleted the 8890-disable-sims branch February 21, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cosmos Agoric tags for cosmos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sims workflow in agoric-labs/cosmos-sdk is always cancelled
2 participants