Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose txHash and msgIdx in ctx #300

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

mhofman
Copy link

@mhofman mhofman commented Mar 4, 2023

Description

In order to support Agoric/agoric-sdk#7102 and future shared context between golang and JS, we need to build a unique context for actions pushed to cosmic-swingset on the cosmos side.

This change adds the "transaction hash" and "message index" within that transaction to the message context, which allow to uniquely identify actions and link them to their origin while pushing them to JS.


Author Checklist

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Collaborator

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @JimLarson may want to opine before merging.

@mhofman mhofman force-pushed the mhofman/7102-action-queue-context branch from e713869 to 98c021a Compare March 14, 2023 22:42
Copy link

@JimLarson JimLarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhofman mhofman merged commit 2109765 into Agoric Mar 20, 2023
@mhofman mhofman deleted the mhofman/7102-action-queue-context branch March 20, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants