bug: merge the logRecord resources with those provided by the logProvider #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chameleon82
reviewed
Oct 13, 2023
| @@ -40,7 +40,10 @@ func (l logger) Emit(logRecord logs.LogRecord) { | |||
| return | |||
| } | |||
|
|
|||
| pr := l.provider.resource | |||
| pr, err := resource.Merge(l.provider.resource, logRecord.Resource()) | |||
There was a problem hiding this comment.
Thanks for the suggestion.
That sound more to be a Scope Resource and we have it defined in proto and model.
and correct implementation should be
pr, err := logRecord.Resource()
But from this point provider resource lost and should be taken in LogRecordProcessor implementation. However,
we don't have another way yet to access LoggerProvider resources in the Exporter
I will merge that MR to have both resources merged as currently logs is not getting grouped by resource/scope when sent to OTLP, but this should be refactored in the future.
chameleon82
changed the title
This was referenced Oct 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables customizing the resource attributes for any emitted logRecord.
In our specific use case, our monitoring agent collects logs of every container running on a node and subsequently sends these logs to the OpenTelemetry collector. Therefore, we need to set the
container.idandservice.nameresource attributes for each log entry emitted.