You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Graceful shutdown is no longer available in hyper 1.0 and thus in axum 0.7. There is open issue for it to be re-added in hyper-utils: hyperium/hyper#2862
The new way of doing graceful shutdown is to manually implement the server (axum::serve method) and it also forces the choice to exclusively use http1(.1) or http2. Neither is very appealing with the latter being a deal breaker.
Current implementation simply cancels the server possibly causing data loss for clients. The databases even for open transactions will be ok (on drop the transactions get aborted and data integrity restored due to write ahead log (WAL) ).
Two options:
Prevent client data loss by tracking open requests and stopping serving new ones (probably in the logger layer?) when shutdown is invoked. Let the main cancel the server as normal once the ongoing requests reach 0.
Use proper graceful shutdown when it becomes available in hyper.
The text was updated successfully, but these errors were encountered:
Graceful shutdown is no longer available in hyper 1.0 and thus in axum 0.7. There is open issue for it to be re-added in hyper-utils: hyperium/hyper#2862
The new way of doing graceful shutdown is to manually implement the server (
axum::serve
method) and it also forces the choice to exclusively use http1(.1) or http2. Neither is very appealing with the latter being a deal breaker.Current implementation simply cancels the server possibly causing data loss for clients. The databases even for open transactions will be ok (on drop the transactions get aborted and data integrity restored due to write ahead log (WAL) ).
Two options:
Prevent client data loss by tracking open requests and stopping serving new ones (probably in the logger layer?) when shutdown is invoked. Let the main cancel the server as normal once the ongoing requests reach 0.
Use proper graceful shutdown when it becomes available in hyper.
The text was updated successfully, but these errors were encountered: