Rails 4.0 upgrade #114
Comments
hugocorbucci
pushed a commit
that referenced
this issue
Dec 18, 2014
hugocorbucci
pushed a commit
that referenced
this issue
Dec 19, 2014
Should help with #114. Also better than jasmine.
hugocorbucci
pushed a commit
that referenced
this issue
Dec 19, 2014
Can't get rid of the action_class and input_class deprecations until finishing #114. Will need to update the formtastic initializer to add the input class and action class initializers as explained in https://github.com/justinfrench/formtastic/wiki/Upgrading-to-Formtastic-3.1
hugocorbucci
pushed a commit
that referenced
this issue
Dec 19, 2014
Nothing specific about this one but good for upgrading jquery-rails when issue #114 is done.
hugocorbucci
referenced
this issue
Dec 22, 2014
Aside from the strong parameters and the devise changes, most of it is fairly straightforward. Threw away all of the activities code that we no longer use as it will be part of the scheduling system whenever we need it.
hugocorbucci
pushed a commit
that referenced
this issue
Dec 22, 2014
Can't make use of the secrets.yml yet until the deployment and environments change to have the ENV variable. State machine needed the around validation extension to be compatible with active record 4.1. All the JS ajax tests had to explicitly change to be xhr requests instead of regular get or posts. Remove the none scope from session as AR now includes by default for all models.
hugocorbucci
pushed a commit
that referenced
this issue
Dec 24, 2014
hugocorbucci
pushed a commit
that referenced
this issue
Jun 29, 2015
Turns out that as part of #114, `validates :field, acceptance: true` works great for fields that are NOT under ActiveRecord's control (such as reviewer_agreement since you can only be a reviewer if you agree). However, it requires a change for fields that ARE under ActiveRecord's control (such as author_agreement in a Session). As part of 8ab435d, I found the problem with Session and fixed it. However, since the construct was the same for Reviewer, I made the mistake of changing it to `validates :reviewer_agreement, acceptance: { accept: true}` too. Unfortunately, values coming from the browser are left as '0' and '1' instead of false or true. As a result, browser submissions of accepting the reviewer agreement would not validate.
This was referenced Jun 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rails 4 is out. A lot of gems are Ruby 1.9+ and rails 4 is a good drive for that.
The text was updated successfully, but these errors were encountered: