feat: Add multiple invalidations based on stages #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2020 14:31
Before this commit, `cloudfrontInvalidation` was a single object under the
`custom` section of serverless.yml file. There was no possible way to create
invalidations for multiple CloudFront distributions. Therefore, the
`cloudfrontInvalidation` object is turned into a list that can contain
multiple distributions. index.js file is modified to realize this feature.
The function body in `invalidate()` is moved into
`...cloudfrontInvalidation.forEach()`
Besides, an option of create invalidations based on deployment stages
was also not available. Hence, an optional `stage` property is added for
each distribution element. An if statement that checks for `stage` property
declaration and its matching with the provider's stage is added into
`invalidate()` in index.js file.
The Setup example of `cloudfrontInvalidation` as a list and the Setup
example of using the `stage` property of the elements of
`cloudfrontInvalidation` is added to README.md file.
Modified files:
- index.js
- README.md
…sing modified: README.md
|
Hi @aghadiry, could you take a look at this pull request? |
|
@aghadiry @AllegraChen next time please mention this kind of changes as BREAKING (so release a major, not a minor). I updated from 1.5 to 1.8 and builds started to fail due to the plugin assuming the config is an array. |
mihaerzen
pushed a commit
to mihaerzen/serverless-cloudfront-invalidate
that referenced
this pull request
Aug 24, 2021
as it was broken with aghadiry#19
This was referenced Aug 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
cloudfrontInvalidationwas a single object under thecustomsection of serverless.yml file. There was no possible way to create invalidations for multiple CloudFront distributions. Therefore, thecloudfrontInvalidationobject is turned into a list that can contain multiple distributions. The index.js file is modified to realize this feature. The function body ininvalidate()is moved into...cloudfrontInvalidation.forEach(). This feature is also mentioned in issue #8.Besides, an option of create invalidations based on deployment stages was also not available. Hence, an optional
stageproperty is added for each distribution element. An if statement that checks forstageproperty declaration and its matching with the provider's stage is added intoinvalidate()in index.js file.The Setup example of
cloudfrontInvalidationas a list and the Setup example of using thestageproperty of the elements ofcloudfrontInvalidationis added to README.md file.