This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Rename project #52
Merged
Rename project #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Should we rename docker/data/beethoven and docker/data/beethoven/beethoven.toml also?
In the beethoven.toml, there are references to beethoven-db, beethoven_user, beethoven_password etc.
The docker/data/zkevm/node.toml also contains some references to beethoven.
It should be evaluated whether it is safe to rename all those occurences.
|
Renamed @Stefan-Ethernal vscode didn't search them because the path is in .gitignore. It should be safe AFAIK |
Stefan-Ethernal
approved these changes
Jan 25, 2024
rachit77
approved these changes
Jan 25, 2024
Co-authored-by: Stefan Negovanović <[email protected]>
Co-authored-by: Stefan Negovanović <[email protected]>
Co-authored-by: Stefan Negovanović <[email protected]>
… vcastellm/rename
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename project to final name