Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Modularize Beethoven logic #29

Merged
merged 31 commits into from
Jan 10, 2024
Merged

Modularize Beethoven logic #29

merged 31 commits into from
Jan 10, 2024

Conversation

vcastellm
Copy link
Contributor

Refactor RPC code to something more abstract, modularized into the interop package and Executor object. This should be more unit testing friendly.

Note that this is still WIP, it's missing tests, and probably an interface.

Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posting some early feedback.

interop/verify.go Outdated Show resolved Hide resolved
interop/query.go Outdated Show resolved Hide resolved
@vcastellm vcastellm marked this pull request as ready for review January 2, 2024 11:40
@christophercampbell
Copy link
Contributor

Do you think it is worth extracting an interface for executor?

@vcastellm
Copy link
Contributor Author

Do you think it is worth extracting an interface for executor?

I would not do it if we don't need it yet, wdyt?

interop/executor_test.go Outdated Show resolved Hide resolved
interop/executor_test.go Outdated Show resolved Hide resolved
interop/executor_test.go Outdated Show resolved Hide resolved
interop/executor.go Outdated Show resolved Hide resolved
interop/executor.go Outdated Show resolved Hide resolved
interop/executor.go Show resolved Hide resolved
interop/executor.go Outdated Show resolved Hide resolved
interop/executor.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
81.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vcastellm vcastellm merged commit eca12c0 into main Jan 10, 2024
6 checks passed
@vcastellm vcastellm deleted the vcastellm/refactor_rpc branch January 10, 2024 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants