This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Adding authorized proof signers mapping #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praetoriansentry
changed the title
vcastellm
reviewed
Mar 30, 2024
goran-ethernal
approved these changes
Mar 30, 2024
rachit77
approved these changes
Mar 30, 2024
vcastellm
force-pushed
the
jhilliard/authorized-signers
branch
3 times, most recently
from
9909751
to
47ab08c
Compare
* Test arbitrary configured signer * Modify the workflow so we can omit the request when there's a locally configured signer
vcastellm
force-pushed
the
jhilliard/authorized-signers
branch
from
47ab08c
to
af20f1f
Compare
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the AggLayer service requires that the party submitting the proof sign the request with the trusted sequencer's key. This makes sense given that we can easily verify the trusted sequencer from the rollup contract.
This PR adds an alternative configuration which would allow for a proof to be submitted using a configurable key rather than the sequencer key. This should allow for better isolation of key material because the sequencer key will not need to be used by multiple roles.
Part of the aim here is to be minimally invasive in this changeset. We're not changing the beneficiary logic at all and specifically allowing for an alternative signer.
Most of the testing for this takes place in 0xPolygon/kurtosis-cdk#38 allowed me to try a few cases:
[ProofSigners]section is missingAs an example this is what the config would look like: