Implement auto-embedding of video URLs [fixed] #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses WordPress wp_oembed_get function to auto-embed YouTube/Vimeo links etc.
Simplify code by introducing $video_url variable and updates to support a false return value from wp_oembed_get. Could probably still use better URL detection (such as if the admin enters a URL without the ‘http://'
Use esc_url as per wp codex.
davebonds
approved these changes
Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change auto-detects the use of an embeddable video URL and automatically embeds the video when possible, falling back to existing behaviour of displaying the link.