Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mechanism to compile Haskell.Data.* modules to Data.* modules #297

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

viktorcsimma
Copy link
Contributor

@viktorcsimma viktorcsimma commented Mar 1, 2024

I've opened a separate PR for this. There is now a list of module prefixes which get compiled to corresponding Haskell modules. E.g. Haskell.Data.Map becomes Data.Map.

Actually, the test files used depend on maps; so I can only add them after they get merged (I'll include them in the Map PR)

@viktorcsimma
Copy link
Contributor Author

Now added Haskell.Control, too (that is going to be important for #298).

@omelkonian
Copy link
Contributor

Have you considered extending the "rewrite-rules" mechanism for providing these translation? IMO this is preferable to polluting the code base with such ad-hoc configurations.

@viktorcsimma
Copy link
Contributor Author

I think it would be better for it to work out-of-the-box as the user expects them. But in fact, we could include some kind of "default" configuration file to which we move both this and defaultSpecialRules in Name.hs. Do you think about something like this, or do I miss the point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants