Implement IsPullback suggestions #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched the places of unique and unique-diagram for both pullbacks and pushouts; unique is now derived from unique-diagram.
src/Categories/Category/Instance/Properties/Setoids/Extensive.agda
Outdated
Show resolved
Hide resolved
src/Categories/Category/Instance/Properties/Setoids/Extensive.agda
Outdated
Show resolved
Hide resolved
| ; p₁∘universal≈h₁ = X.refl | ||
| ; p₂∘universal≈h₂ = Y.refl | ||
| ; unique-diagram = λ eq₁ eq₂ → eq₁ , eq₂ |
There was a problem hiding this comment.
It doesn't seem like that will work, because there is an implicit argument after eq₂
|
What about naming? Is |
|
Thanks for the updates (and sorry on my slowness!). On name: |
|
I don't really think the name needs to change. I just wanted to make sure there wasn't an obviously-better alternative before I consider the PR done. |
|
Sure, we can go with that and see if people complain. |
JacquesCarette
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to address issue #334.
Tasks:
uniquefield to bottomuniquewithunique-diagram