Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the i18next eslint plugin #731

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Use the i18next eslint plugin #731

merged 1 commit into from
Sep 1, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Sep 1, 2023

Problem

  • We do not automatically scan the web UI for untranslated texts, we can easily miss some translations

Solution

Notes

  • This is not a perfect solution, it reports only string literals, it cannot find cases like this:
// missing translation
const msg = "message";
...
<b>{msg}</b>
  • However, it still found like a half dozen of missing translations so it still makes sense

...to find all untranslated text literals

- fixed found problems
@lslezak lslezak merged commit 07f5da1 into master Sep 1, 2023
8 of 10 checks passed
@lslezak lslezak deleted the eslint-plugin-i18next branch September 1, 2023 11:11
@imobachgs imobachgs mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants