-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy install #711
Proxy install #711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, although I think that the logic to handle the proxy configuration should be in the Network service (instead of the Manager). However, let's consider the current implementation good enough.
Please add the entry to the changes file.
I agree, lets do it separately by now and then integrate it in the network service implementing it completely in Rust. |
BTW, the integration tests are failing, but it is a known (and already) fixed issue. It would be fine after you merge. |
fee7ad4
to
393e021
Compare
Rebased with master and added changelog |
Problem
In #696 we added support for configuring the proxy when booting the installation system but the configuration is lost after the installation.
Solution
The proxy configuration will be copied to the target system when a proxy is used as well as the microos-tools package will be installed.
Testing