Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Do not show group options name until needed #555

Merged
merged 2 commits into from
May 2, 2023

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented May 2, 2023

Problem

During a review meeting, we've spot that displaying the group options name when there is only a single group of options can be more confusing than helpful.

Solution

Display the group name only when needed. I.e., when really having more than one group of actions for a set of page options.

Testing

  • Added a new unit test
  • Tested manually

Notes

Since it's related with #545 and it has not been merged to master yet, this PR belongs to the same changelog entry. No extra one needed, IMHO.

Screenshots

Before After
Screenshot from 2023-05-02 10-10-53 Screenshot from 2023-05-02 10-10-45

@dgdavid dgdavid requested a review from ancorgs May 2, 2023 09:17
@github-actions
Copy link

github-actions bot commented May 2, 2023

Pull Request Test Coverage Report for Build 4859591904

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 74.167%

Totals Coverage Status
Change from base Build 4818237491: 0.1%
Covered Lines: 4857
Relevant Lines: 6318

💛 - Coveralls

@dgdavid dgdavid changed the title [web] Do not show group options label until needed [web] Do not show group options name until needed May 2, 2023
@dgdavid dgdavid force-pushed the improve-storage-options branch from b1bda09 to 517ce97 Compare May 2, 2023 09:26
@dgdavid dgdavid force-pushed the improve-storage-options branch from 517ce97 to 48dfa5b Compare May 2, 2023 09:27
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgdavid dgdavid merged commit a1cf46e into issues May 2, 2023
@dgdavid dgdavid deleted the improve-storage-options branch May 2, 2023 09:34
@joseivanlopez joseivanlopez mentioned this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants