Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web) avoid PF/Radio complaint at product selection #1689

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(web) avoid PF/Radio complaint at product selection #1689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions web/src/assets/styles/app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,16 @@ button.remove-link:hover {
}

#productSelectionForm {
.pf-v5-c-radio input {
input[type="radio"] {
align-self: center;
width: 20px;
height: 20px;
flex-shrink: 0;
inline-size: 20px;
block-size: 20px;
}

.pf-v5-c-card {
img {
width: 80px;
max-inline-size: 80px;
}

label {
Expand Down
15 changes: 10 additions & 5 deletions web/src/components/product/ProductSelectionPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import {
Form,
Grid,
GridItem,
Radio,
List,
ListItem,
Split,
Expand All @@ -39,7 +38,8 @@ import {
import { Page } from "~/components/core";
import { Center } from "~/components/layout";
import { useConfigMutation, useProduct } from "~/queries/software";
import styles from "@patternfly/react-styles/css/utilities/Text/text";
import pfTextStyles from "@patternfly/react-styles/css/utilities/Text/text";
import pfRadioStyles from "@patternfly/react-styles/css/components/Radio/radio";
import { slugify } from "~/utils";
import { sprintf } from "sprintf-js";
import { _ } from "~/i18n";
Expand All @@ -63,16 +63,21 @@ const Option = ({ product, isChecked, onChange }) => {
<Card isRounded>
<CardBody>
<Split hasGutter>
<Radio
<input
id={id}
type="radio"
name="product"
isChecked={isChecked}
className={pfRadioStyles.radioInput}
checked={isChecked}
onChange={onChange}
aria-details={detailsId}
/>
<img aria-hidden src={logoSrc} alt={logoAltText} />
<Stack hasGutter>
<label htmlFor={id} className={`${styles.fontSizeLg} ${styles.fontWeightBold}`}>
<label
htmlFor={id}
className={`${pfTextStyles.fontSizeLg} ${pfTextStyles.fontWeightBold}`}
>
{product.name}
</label>
<p id={detailsId}>{product.description}</p>
Expand Down
Loading