-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): start using TypeScript #1456
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6bf371b
feat(web): add support for TypeScript
dgdavid d8b65ff
feat(web): bring back types for L10n
dgdavid 27054cd
feat(web): enable jest TypeScript support
dgdavid 4b622bb
fix(web): declare InstallerClient#ws
dgdavid e93551d
doc(web): Add changelog entry
dgdavid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
type Keymap = { | ||
/** | ||
* Keyboard id (e.g., "us"). | ||
*/ | ||
id: string; | ||
/** | ||
* Keyboard name (e.g., "English (US)"). | ||
*/ | ||
name: string; | ||
}; | ||
|
||
type Locale = { | ||
/** | ||
* Language id (e.g., "en_US.UTF-8"). | ||
*/ | ||
id: string; | ||
/** | ||
* Language name (e.g., "English"). | ||
*/ | ||
name: string; | ||
/** | ||
* Territory name (e.g., "United States"). | ||
*/ | ||
territory: string; | ||
}; | ||
|
||
type Timezone = { | ||
/** | ||
* Timezone id (e.g., "Atlantic/Canary"). | ||
*/ | ||
id: string; | ||
/** | ||
* Name of the timezone parts (e.g., ["Atlantic", "Canary"]). | ||
*/ | ||
parts: string[]; | ||
/** | ||
* Name of the country associated to the zone or empty string (e.g., "Spain"). | ||
*/ | ||
country: string; | ||
/** | ||
* UTC offset. | ||
*/ | ||
utcOffset: number; | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, I didn't realize I sent these (and others) format changes made by Zed editor which I'm testing. Will revert them in a new commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a short discussion with @imobachgs, I will keep it as it is because we're gonna format all the code base for consistence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, the format change was not because Zed but because Zed applying the rules we have at .prettierrc file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done at #1460