Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): Fetch all history #1296

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix(CI): Fetch all history #1296

merged 1 commit into from
Jun 10, 2024

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Jun 10, 2024

Problem

  • The packages in the Staging project have RPM versions like 1717740471.88237f7b, e.g. Unix time stamp + short commit SHA
  • It should be something like 8+192, i.e. the latest version tag + number of commits since then
  • The problem is that the cloned Git repository in CI does not contain any tags

Solution

  • We need to find the latest version tag in the history. By default the action/checkout uses "--depth 1" parameter which fetches only a single commit without history. I guess this problem was introduces by upgrading actions/checkout to version 4.
  • The fix is to checkout the complete history

Notes

  • I found a solution which allows to fetch history only up to a specified tag, this decreases the amount of data to download as it does not fetch the complete history.
  • However, finding the latest tag on the server and the downloading the content using several commands has a big overhead. Currently downloading the whole history is faster than this optimized process. It would make sense only on a really slow internet connection. With any decent connection the full clone is faster.
  • But I guess that at some point in the future, when the Git history grows a lot, this approach will be faster and more efficient

We need to find the latest version tag in the history.
By default the action/checkout uses "--depth 1" parameter
which fetches only a single commit without history.
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 4e36bfd into master Jun 10, 2024
@lslezak lslezak deleted the fix_submit_version branch June 10, 2024 07:42
@mvidner
Copy link
Contributor

mvidner commented Jun 10, 2024

@lslezak Arguably this is a bug in the github action or its documentation, fetch-tags is ineffective alone.

@imobachgs imobachgs mentioned this pull request Jun 27, 2024
imobachgs added a commit that referenced this pull request Jun 27, 2024
Prepare for releasing Agama 9. It includes the following pull requests:

- #1101
- #1202
- #1228
- #1231
- #1236
- #1238
- #1239
- #1240
- #1242
- #1243
- #1244
- #1245
- #1246
- #1247
- #1248
- #1249
- #1250
- #1251
- #1252
- #1253
- #1254
- #1255
- #1256
- #1257
- #1258
- #1259
- #1260
- #1261
- #1264
- #1265
- #1267
- #1268
- #1269
- #1270
- #1271
- #1272
- #1273
- #1274
- #1279
- #1280
- #1284
- #1285
- #1286
- #1287
- #1288
- #1289
- #1290
- #1291
- #1292
- #1293
- #1294
- #1295
- #1296
- #1298
- #1299
- #1300
- #1301
- #1302
- #1303
- #1304
- #1305
- #1306
- #1307
- #1308
- #1309
- #1310
- #1311
- #1312
- #1313
- #1314
- #1315
- #1316
- #1317
- #1318
- #1319
- #1320
- #1321
- #1322
- #1323
- #1324
- #1325
- #1326
- #1328
- #1329
- #1331
- #1332
- #1334
- #1338
- #1340
- #1341
- #1342
- #1343
- #1344
- #1345
- #1348
- #1349
- #1351
- #1352
- #1353
- #1354
- #1355
- #1356
- #1357
- #1358
- #1359
- #1360
- #1361
- #1362
- #1363
- #1365
- #1366
- #1367
- #1368
- #1371
- #1372
- #1374
- #1375
- #1376
- #1379
- #1380
- #1381
- #1383
- #1384
- #1385
- #1386
- #1387
- #1388
- #1389
- #1391
- #1392
- #1394
- #1395
- #1397
- #1398
- #1399
- #1400
- #1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants