Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Storage Result Section #1078

Closed
wants to merge 12 commits into from
Closed

WIP: Storage Result Section #1078

wants to merge 12 commits into from

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Mar 6, 2024

🚧 WIP 🚧

This PR is part of the work for a new presentation of the storage proposal result.

It will be better documented once the PR is more mature. Meanwhile, check https://trello.com/c/7TTVVquM (internal link) for more details about the progress.


Screenshot from 2024-03-06 17-38-35

@dgdavid dgdavid requested review from joseivanlopez and ancorgs March 6, 2024 17:39
@dgdavid dgdavid self-assigned this Mar 6, 2024
@joseivanlopez
Copy link
Contributor

joseivanlopez commented Mar 7, 2024

I like how it looks! And definitely is going to help a lot! We still have to think a proper wording for the delete warning (not only partitions can be deleted) and how to show the list of deleted devices. And, looking at the table, I think having the "New" prefix for things that are going to be created is very useful (e.g., "New XFS partition").

BTW, the unused space looks much better I thought.

@dgdavid
Copy link
Contributor Author

dgdavid commented Mar 7, 2024

Proposals for listing what is going to be deleted,

Using a table hiding headers Using a list
Screenshot from 2024-03-07 09-32-17 Screenshot from 2024-03-07 09-39-06

As a first attempt, I prefer the second one. Of course, we can improve such a presentation little by little in future iterations, but now I want to go for something simple.

@ancorgs
Copy link
Contributor

ancorgs commented Mar 7, 2024

Looks quite ok in general. I just want to see more clearly:

  • Which devices (partitions, volume groups, etc.) are new
  • Which devices has been resized

I'm also considering whether it would be beneficial to somehow empathize the devices that are part of the new system, so they are identified more easily. That would include devices with a mount point, physical volumes, devices created for booting like PReP or bios_boot... But I fear it would be too much visual information and I trust I good visualization of what is new and what is resized should be enough to get the full picture.

@joseivanlopez joseivanlopez force-pushed the storage-result-action branch from 638b34c to 8c3b701 Compare March 8, 2024 14:43
@coveralls
Copy link

coveralls commented Mar 8, 2024

Coverage Status

coverage: 74.595% (+0.1%) from 74.46%
when pulling 10ddf9b on storage-result-action
into e35d470 on storage-ui.

@dgdavid
Copy link
Contributor Author

dgdavid commented Mar 11, 2024

Closing it in favor of #1088

@dgdavid dgdavid closed this Mar 11, 2024
@ancorgs ancorgs deleted the storage-result-action branch May 13, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants