-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Storage Result Section #1078
Conversation
I like how it looks! And definitely is going to help a lot! We still have to think a proper wording for the delete warning (not only partitions can be deleted) and how to show the list of deleted devices. And, looking at the table, I think having the "New" prefix for things that are going to be created is very useful (e.g., "New XFS partition"). BTW, the unused space looks much better I thought. |
Looks quite ok in general. I just want to see more clearly:
I'm also considering whether it would be beneficial to somehow empathize the devices that are part of the new system, so they are identified more easily. That would include devices with a mount point, physical volumes, devices created for booting like PReP or bios_boot... But I fear it would be too much visual information and I trust I good visualization of what is new and what is resized should be enough to get the full picture. |
- Unit tests not adapted yet
- Unit tests not adapted yet
638b34c
to
8c3b701
Compare
Closing it in favor of #1088 |
🚧 WIP 🚧
This PR is part of the work for a new presentation of the storage proposal result.
It will be better documented once the PR is more mature. Meanwhile, check https://trello.com/c/7TTVVquM (internal link) for more details about the progress.