Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong encoding of Swedish letters + gnome-terminal not starting #987

Closed
bittin opened this issue Jan 10, 2024 · 6 comments
Closed

wrong encoding of Swedish letters + gnome-terminal not starting #987

bittin opened this issue Jan 10, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@bittin
Copy link

bittin commented Jan 10, 2024

Hey!

i have been testing Agama with openSUSE Tumbleweed during the first month of this year
and the encoding of letters is wrong in the Wayland GNOME Environment for example when it creates the Downloads folder its called Hämtningar instead of Downloads

and also it has problems with launching gnome-terminal # Error constructing proxy for org.gnome.Terminal:/org/gnome/Terminal/Factory0: Fel vid anrop av StartServiceByName för org.gnome.Terminal: Tidsgränsen uppnåddes
tried to start it with english language but got the exact same problem: # Error constructing proxy for org.gnome.Terminal:/org/gnome/Terminal/Factory0: Error calling StartServiceByName for org.gnome.Terminal: Timeout was reached

xfce4-terminal works however

@imobachgs imobachgs added the bug Something isn't working label Jan 10, 2024
@imobachgs
Copy link
Contributor

This problem does not happen on a system installed using YaST. That's why we think it is a bug.

@mvidner
Copy link
Contributor

mvidner commented Jan 10, 2024

This kind of garbled text means the text is encoded in UTF-8 (as expected) but the terminal interprets it as ISO-8859-x.

Hypothesis: we write the locale identifier as sv_SE (which is fine on the web) but that one uses ISO-8859-1 in Linux. We should write sv_SE.UTF-8 instead.

$ locale -av
...
locale: sv_SE           directory: /usr/lib/locale/sv_SE
-------------------------------------------------------------------------------
    title | Swedish locale for Sweden
 language | Swedish
territory | Sweden
  codeset | ISO-8859-1

locale: sv_SE.utf8      directory: /usr/lib/locale/sv_SE.utf8
-------------------------------------------------------------------------------
    title | Swedish locale for Sweden
 language | Swedish
territory | Sweden
  codeset | UTF-8
...

@imobachgs imobachgs self-assigned this Jan 10, 2024
@imobachgs
Copy link
Contributor

Hi all,

Thanks @mvidner, you are right! I confirmed that we are not including the encoding. We could 1) force to use UTF-8 always (which is almost a one-liner) or 2) take the encoding into account (which looks more correct to me). I am working on the solution 2).

imobachgs added a commit that referenced this issue Jan 16, 2024
## Problem

See #987.

## Solution

* The encoding should be included in the locale, although at this point
we always use `UTF-8` (check `localectl list-locales`).
* I adapted the web UI to ignore the encoding (it is only interested in
the language).

## Updating the spec file

I updated the `spec` file according to the latest changes of
cargo_vendor:

```
* cargo_config is no longer created - it's part of the vendor.tar now
    * You can safely remove lines related to cargo_config from your spec file

* multiple cargotoml files can be specified and share a single vendor.tar
    * If multiple cargo.toml files are present update does not work. This is a known
      limitation of the process

* cargo_audit is now part of cargo_vendor, meaning you don't have to configure it separately
```

## Testing

* Manually tested using a branch in OBS.
@imobachgs
Copy link
Contributor

Once #992 has been merged, I will consider the issue solved. I have installed the system in Swedish and it seems to work:

Captura desde 2024-01-16 13-38-32

Thanks for the report!

@bittin
Copy link
Author

bittin commented Jan 16, 2024

Once #992 has been merged, I will consider the issue solved. I have installed the system in Swedish and it seems to work:

Captura desde 2024-01-16 13-38-32

Thanks for the report!

was actually my partner @lemonzest79 that found this bug before me, but glad to see it now being solved in tomorrows daily image

@bittin
Copy link
Author

bittin commented Jan 17, 2024

i can confirm this now works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants