Extract issues link from sidebar

[joseivanlopez]

We have agreed to use the sidebar for actions related to the installer itself (e.g., diagnosis tools, display lang, etc). Everything related to the target system to install should not be placed in the siderbar.

The only thing related to the target system still present in the sidebar is the issues link. The issues should be globally accessible from another place (footer, header, ...).

[dgdavid]

You were faster than me :) I was redacting the issue for exactly the same, after a morning meeting with @imobachgs for reviewing pending stuff in the Agama UI and generating some detailed issues.

What is more, I was thinking on @balsa-asanovic for this one, as I got the impression he wanted to continue contributing. But, of course, it's just a suggestion.

In any case, I'll add my view as a comment here as soon as I finish it.

[balsa-asanovic]

What is more, I was thinking on @balsa-asanovic for this one, as I got the impression he wanted to continue contributing. But, of course, it's just a suggestion.

Agreed. 👍

Also, if there are some other issues you think I could help with, feel free to suggest those as well.

[dgdavid]

We have agreed to use the sidebar for actions related to the installer itself (e.g., diagnosis tools, display lang, etc). Everything related to the target system to install should not be placed in the siderbar.

The only thing related to the target system still present in the sidebar is the issues link. The issues should be globally accessible from another place (footer, header, ...).

Exactly, the progression of Agama's UI somehow has relegated the Sidebar to an area for holding stuff related to Agama itself and the main area for everything related to the system that will be installed.

This means that we should remove the "Show issues" link as it links to a page that shows issues related to the target system rather than the installer. In addition, currently this links takes to a dedicated "Issues page" that allows navigating back to where the user was. However, using a popup issues could be displayed anywhere the users are, remaining them in the same place after closing such a dialog without navigating back and forward.

This solution has another advantage: we would be able to remove the popover to display the errors found in each section on the overview page, which we were not entirely satisfied with.

With all of the above in mind, the tasks would be

• Convert the IssuesPage to a popup dialog

• Drop IssuesLink from the Sidebar (currently mounted in App.jsx)

• Put an icon button on the header, close to the hamburger menu, to open the Issues dialog.

  • For now, mount it in the Sidebar, inside AppActions slot. This is going to change, but it's the simplest approach to have the behavior working as expected.

  • Use the warning icon, although other suggestions are of course welcome.

  • Display it only if there are issues.

• Stop using the NotificationMark. The new warning button in the header will be enough for letting the user know that there are issues.

• Drop the NotificationMark code.

• Stop using the Popover in the core/ValidationErrors component. Instead, allows the "% errors found" button to open the Issues dialog. Ideally, it should scroll to the corresponding section and highlight it. In the meantime, scrolling is a good starting point, since we still need to determine how to highlight it. Think that each section in the Issues dialog should have a predictable id (which makes me remind Define when should we use the `id` attribute. #811 (comment)) to be used as an anchor. We can talk about it when developing the feature.

The above should be more than enough for a complete PR. Please, don't hesitate to ask as much as needed.