Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agama questions mode non-interactive error: Unknown method SetInteractive #709

Closed
mvidner opened this issue Aug 21, 2023 · 4 comments
Closed

Comments

@mvidner
Copy link
Contributor

mvidner commented Aug 21, 2023

Our CLI calls a org.opensuse.Agama.Questions1.SetInteractive method on /org/opensuse/Agama/Questions1 but the actual API is an Interactive property.

It is declared so in the proxies.rs file.

@mvidner
Copy link
Contributor Author

mvidner commented Aug 21, 2023

in https://docs.rs/zbus/3.12.0/zbus/attr.dbus_proxy.html there is an example where you have to prefix #[dbus_proxy(property)] also at the set_foo function:

#[dbus_proxy(...)]
trait SomeIface {
    #[dbus_proxy(property)]
    fn a_property(&self) -> fdo::Result<String>;

    #[dbus_proxy(property)]  // HERE!
    fn set_a_property(&self, a_property: &str) -> fdo::Result<()>;
}

our proxies.rs is missing those

@jreidinger
Copy link
Contributor

Bug is in xmlgen which does not add another property macro if property is rw https://github.com/dbus2/zbus/blob/main/zbus_xmlgen/src/lib.rs#L86

@jreidinger
Copy link
Contributor

but also their tests contain same output, so we need to ensure what is proper output https://github.com/dbus2/zbus/blob/main/zbus_xmlgen/tests/data/sample_object0.rs#L24

mvidner added a commit that referenced this issue Aug 22, 2023
…ractive` (#709)

We want to access Interactive, a writable property.

zbus-xmlgen generates a proxy for setting a writable property but
forgets to mark it as a property, generating a method call instead
mvidner added a commit that referenced this issue Aug 22, 2023
Fix Unknown method: SetInteractive for `agama questions mode non-interactive` (#709)
@ancorgs
Copy link
Contributor

ancorgs commented Nov 30, 2023

I assume this is fixed by #712. If not, please re-open.

@ancorgs ancorgs closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants