Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: unexpected user suggestions behavior #1124

Closed
dgdavid opened this issue Apr 3, 2024 · 2 comments
Closed

web: unexpected user suggestions behavior #1124

dgdavid opened this issue Apr 3, 2024 · 2 comments

Comments

@dgdavid
Copy link
Contributor

dgdavid commented Apr 3, 2024 •
edited
Loading

While reviewing #1122 I have found two unexpected behavior (kind of bugs) that were introduced in #1022

  • The auto suggestions wrapper is shown even when there are no suggestions.

    This only happens the user introduce a very short full name (one or two characters) but not when nothing is typing there.

    0002

  • When there are suggestions and they are shown, the focus stop working as expected. For example, pressing Tab again moves the focus to the PatternFly Backdrop 🤯 which is there because of the modal dialog holding the user form. to the HTML <body>.

    Screenshot from 2024-04-03 08-58-55

    Tabing again moves the focus to the first input, Full name in the mentioned form.
@dgdavid dgdavid mentioned this issue Apr 3, 2024
Merged
@dgdavid
Copy link
Contributor Author

dgdavid commented Apr 3, 2024

  • The auto suggestions wrapper is shown even when there are no suggestions.

This, of course, deserves a test example in the test file.

@dgdavid dgdavid changed the title web: user auto suggestions issues web: unexpected auto suggestions behavior Apr 3, 2024
@dgdavid dgdavid changed the title web: unexpected auto suggestions behavior web: unexpected user suggestions behavior Apr 3, 2024
balsa-asanovic added a commit to balsa-asanovic/agama that referenced this issue Apr 8, 2024
@balsa-asanovic
Hiding suggestions on Tab press fixes unexpected behavior agama-proje…
00b6c53 
…ct#1124
@dgdavid
Copy link
Contributor Author

dgdavid commented May 2, 2024

Fixed by #1122

@dgdavid dgdavid closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgdavid