Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard support for auto-suggested usernames #1070

Closed
dgdavid opened this issue Mar 5, 2024 · 3 comments · Fixed by #1122
Closed

Add keyboard support for auto-suggested usernames #1070

dgdavid opened this issue Mar 5, 2024 · 3 comments · Fixed by #1122
Assignees
@balsa-asanovic

Comments

@dgdavid
Copy link
Contributor

dgdavid commented Mar 5, 2024

The list of suggested usernames introduced on #1022 lacks of keyboard support. A know issue that is going to be addressed when time permits.

Initially we agreed on not opening an specific issue for it and refer to #112 instead.

However, I have though that could be useful to left here some useful articles/docs that might help to implement it. See comments below.
@dgdavid
Copy link
Contributor Author

dgdavid commented Mar 5, 2024

Articles that might help:

@dgdavid
Copy link
Contributor Author

dgdavid commented Mar 5, 2024

@balsa-asanovic, friendly ping

@balsa-asanovic
Copy link
Contributor

Present 😄

Yeah, I'll be taking this one as we talked about it already in the PR regarding the username auto suggest

@balsa-asanovic balsa-asanovic mentioned this issue Mar 27, 2024
Merged
dgdavid added a commit that referenced this issue May 2, 2024
@dgdavid
Added keyboard support when navigating suggested usernames (#1122)
13ddc2e 
## Problem

In #1022 the username auto-suggest feature was introduced, but the
dropdown with usernames didn't support keyboard navigation.

This PR aims to solve this, It introduces navigation with arrow keys (up
and down) and sets the value on the press of Enter.

fixes #1070 

## Solution

Now checking for keyboard events on the username input field and on the
arrow presses changing the index of the selected menu item, highlighting
the appropriate one. On the press of Enter, again using the current
value of index, the text input is populated with a value from the
usernames array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balsa-asanovic balsa-asanovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added keyboard support when navigating suggested usernames balsa-asanovic/agama
2 participants
@dgdavid @balsa-asanovic