Skip to content

Commit

Permalink
Ensure that product icons are packaged (#1587)
Browse files Browse the repository at this point in the history
Hello folks

Here's a fix that ensures installation of missing product icons but I'm
not really happy about two things.

It seems that we're somehow trying to webpack this (I don't really have
experience with this) I know that we're doing some npm installation in
spec so I'm not sure if we should fix the webpack instead.

```
{_builddir}/agama/src/assets/products/*.svg
web/webpack.config.js:  { from: "./src/assets/products/*.svg", to: "assets/logos/[name][ext]" }

```

Why do we have it in src/assets/products/*.svg and install it into
assets/logos/*.svg ?
Let's just use same path in both cases. 

Cheers


![image](https://github.com/user-attachments/assets/4440f5ec-7479-43df-9eed-f69631bf9e65)
  • Loading branch information
imobachgs authored Sep 6, 2024
2 parents 07379e1 + 29267fd commit f05eb53
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions web/package/agama-web-ui.changes
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
-------------------------------------------------------------------
Fri Sep 6 15:04:58 UTC 2024 - Lubos Kocman <[email protected]>

- Ensure that product icons are packaged

-------------------------------------------------------------------
Fri Sep 6 08:06:41 UTC 2024 - Imobach Gonzalez Sosa <[email protected]>

Expand Down
3 changes: 3 additions & 0 deletions web/package/agama-web-ui.spec
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,14 @@ NODE_ENV="production" npm run build
%install
install -D -m 0644 --target-directory=%{buildroot}%{_datadir}/agama/web_ui %{_builddir}/agama/dist/*.{gz,html,js,map,svg}
install -D -m 0644 --target-directory=%{buildroot}%{_datadir}/agama/web_ui/fonts %{_builddir}/agama/dist/fonts/*.woff?
install -D -m 0644 --target-directory=%{buildroot}%{_datadir}/agama/web_ui/assets/logos %{_builddir}/agama/src/assets/products/*.svg

%files
%doc README.md
%license LICENSE
%dir %{_datadir}/agama
%{_datadir}/agama/web_ui
%{_datadir}/agama/assets
%{_datadir}/agama/products

%changelog

0 comments on commit f05eb53

Please sign in to comment.