Skip to content

Commit

Permalink
[web] Drop no longer needed TargetIpsPopup component
Browse files Browse the repository at this point in the history
Now that the Network section summarizes the available connections, this
component is not that relevant. It is being dropped to reduce the confusion of
having two slightly different network summaries in two different locations.
  • Loading branch information
dgdavid committed Mar 13, 2023
1 parent 41fa27a commit 2c71202
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 180 deletions.
2 changes: 0 additions & 2 deletions web/src/components/core/Sidebar.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import React, { useEffect, useRef, useState } from "react";
import { Icon, PageActions, PageOptionsSlot } from "~/components/layout";
import { About, Disclosure, LogsButton, ShowLogButton, ShowTerminalButton } from "~/components/core";
import { TargetIpsPopup } from "~/components/network";

/**
* Internal and memoized component for rendering links only once
Expand Down Expand Up @@ -58,7 +57,6 @@ const FixedLinks = React.memo(() => (
<LogsButton data-keep-sidebar-open="true" />
<ShowTerminalButton />
</Disclosure>
<TargetIpsPopup />
<About />
</div>
), () => true);
Expand Down
1 change: 0 additions & 1 deletion web/src/components/core/Sidebar.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jest.mock("~/components/layout/Layout", () => mockLayout());
jest.mock("~/components/core/About", () => mockComponent(<a href="#">About link mock</a>));
jest.mock("~/components/core/LogsButton", () => mockComponent(<button data-keep-sidebar-open="true">Download logs mock</button>));
jest.mock("~/components/core/ShowLogButton", () => mockComponent(<button href="#">Show logs mock</button>));
jest.mock("~/components/network/TargetIpsPopup", () => mockComponent("Host Ips Mock"));

it("renders the sidebar initially hidden", async () => {
plainRender(<Sidebar />);
Expand Down
89 changes: 0 additions & 89 deletions web/src/components/network/TargetIpsPopup.jsx

This file was deleted.

87 changes: 0 additions & 87 deletions web/src/components/network/TargetIpsPopup.test.jsx

This file was deleted.

1 change: 0 additions & 1 deletion web/src/components/network/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ export { default as DnsDataList } from "./DnsDataList";
export { default as IpAddressInput } from "./IpAddressInput";
export { default as IpPrefixInput } from "./IpPrefixInput";
export { default as IpSettingsForm } from "./IpSettingsForm";
export { default as TargetIpsPopup } from "./TargetIpsPopup";
export { default as WifiConnectionForm } from "./WifiConnectionForm";
export { default as WifiHiddenNetworkForm } from "./WifiHiddenNetworkForm";
export { default as WifiNetworkListItem } from "./WifiNetworkListItem";
Expand Down

0 comments on commit 2c71202

Please sign in to comment.