fix: add nullcheck for legacy speed settings (#1417)

agalwood · Apr 4, 2023 · ecf5958 · ecf5958
1 parent 7201f17
commit ecf5958
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/renderer/components/Preference/Basic.vue b/src/renderer/components/Preference/Basic.vue
@@ -414,7 +414,10 @@
       },
       downloadUnits: {
         get () {
-          const speedEnding = this.form.maxOverallDownloadLimit?.slice(-1)
+          const speed = this.form.maxOverallDownloadLimit
+          // Fallback to K if Speed is 0 (previously unlimited)
+          if (!speed) return 'K'
+          const speedEnding = speed.slice(-1)
           // Fall back to KB if the downloadlimit doesnt have a unit
           if (!speedEnding || !isNaN(parseInt(speedEnding))) return 'K'
           return speedEnding
@@ -425,7 +428,10 @@
       },
       uploadUnits: {
         get () {
-          const speedEnding = this.form.maxOverallUploadLimit?.slice(-1)
+          const speed = this.form.maxOverallUploadLimit
+          // Fallback to K if Speed is 0 (previously unlimited)
+          if (!speed) return 'K'
+          const speedEnding = speed.slice(-1)
           // Fall back to KB if the downloadlimit doesnt have a unit
           if (!speedEnding || !isNaN(parseInt(speedEnding))) return 'K'
           return speedEnding