Avoid attempting to load cubemap when envMap is not set for probe light (fix #5610) #5611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In case no
envMap
was set for a probe light an attempt was still made to load it as a cube map. This resulted in a failed request and an error message in the console (see #5610)This PR updates the
updateProbeLight
function to avoid this as well as clean up the caching logic. The cache would contain promises while the cube map was loading, but these never called theresolve
method. This meant that if two probe lights would load the sameenvMap
one of them would endlessly wait on a never-resolving Promise.Fixes #5610
Changes proposed:
envMap
is not setLightProbe
instance