ar-hit-test: uses 1st tracked controller instead of headset orientation (fix #5315) #5308
+36
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he reticle is placed anywhere
|
Also fixes bug #5315 |
|
hit testing now also tested under Android 13 (on a Pixel 5) |
|
I can confirm that this fixes #5315 for me on multiple Android phones. |
|
This needs rebase. Sorry for the wait. Should we use the controller (inputSource) that trigger the selectstart event vs the first we find? |
dmarcos
changed the title
|
Thanks! |
|
I meant to add that the event is a controllerchange event, so it's not obvious what the relationship is to any selectstart event. It might be possible to figure out which controller was involved, if it was triggered by a controller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When used with a headset capable of AR, the ar-hit-test component currently projects its ray from the headset, which is suboptimal UX when tracked controllers are available.
Changes proposed:
This change adds a new HitTest component, using the first tracked controller's
targetRaySpace.hit-testing has only been tested with a Quest 1 headset