Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset property type needs to parse attrValue when updating #4579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Asset property type needs to parse attrValue when updating #4579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/core/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,11 @@ Component.prototype = {
if (this.isObjectBased) {
parseProperty(attrValue, this.schema);
}
// Assets need parsing otherwise #asset-id will not be converted in url for this.data (ex gltf-model)
if (this.schema.parse.name === 'assetParse') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an exception for a specific parser is brittle. We would need to find a more robust way.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can always call parse function like it happens for components that have schema with more than one property (am I wrong here?) a few lines below the highlighted ones
parseProperties(attrValue, this.schema, true, this.name);

this.data = parseProperty(attrValue, this.schema);
return;
}
// Single-property (already parsed).
this.data = attrValue;
return;
Expand Down