Merge branch 'develop'

afragen · Dec 28, 2018 · 8f48275 · 8f48275
2 parents 700d617 + 2d9595f
commit 8f48275
Show file tree

Hide file tree

Showing 9 changed files with 306 additions and 296 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,11 @@
 #### [unreleased]
 
+#### 8.6.0 / 2018-12-28 🎂
+* add action hook `github_updater_post_rest_process_request` for @Raruto
+* add filter hook `github_updater_set_rollback_package` for @sc0ttclark and @moderntribe
+* return null for `API_Common::parse_release_asset()` when invalid `$response`, fixes [#750](https://github.com/afragen/github-updater/issues/750)
+* make GitHub private repos with release assets use redirect for download link, fixes [#751](https://github.com/afragen/github-updater/issues/751)
+
 #### 8.5.2 / 2018-12-10
 * fixed parsing of wp.org readme changelog items
 

diff --git a/github-updater.php b/github-updater.php
@@ -12,7 +12,7 @@
  * Plugin Name:       GitHub Updater
  * Plugin URI:        https://github.com/afragen/github-updater
  * Description:       A plugin to automatically update GitHub, Bitbucket, GitLab, or Gitea hosted plugins, themes, and language packs. It also allows for remote installation of plugins or themes into WordPress.
- * Version:           8.5.2
+ * Version:           8.6.0
  * Author:            Andy Fragen
  * License:           GNU General Public License v2
  * License URI:       http://www.gnu.org/licenses/gpl-2.0.html
@@ -39,7 +39,7 @@
 		/* translators: 1: minimum PHP version required, 2: Upgrade PHP URL */
 		wp_kses_post( __( 'GitHub Updater cannot run on PHP versions older than %1$s. <a href="%2$s">Learn about upgrading your PHP.</a>', 'github-updater' ) ),
 		'5.6.0',
-		esc_url( __( 'https://wordpress.org/support/upgrade-php/' ) )
+		esc_url( __( 'https://wordpress.org/support/update-php/' ) )
 	);
 	echo '</p></div>';
 

diff --git a/js/ghu-install-vanilla.js b/js/ghu-install-vanilla.js
@@ -11,33 +11,33 @@
 (function () {
 
 	// Hide non-default (Bitbucket & GitLab) settings on page load.
-	var nonDefault = ['bitbucket', 'gitlab', 'gitea', 'zipfile'];
+	let nonDefault = ['bitbucket', 'gitlab', 'gitea', 'zipfile'];
 
 	nonDefault.forEach(function (item) {
-		var parents = getParents(item, 'tr');
+		let parents = getParents(item, 'tr');
 		displayNone(parents);
 	});
 
 	// When the api selector changes.
-	var selects = document.querySelector('select[ name="github_updater_api" ]');
+	let selects = document.querySelector('select[ name="github_updater_api" ]');
 
 	// Only run when on proper tab.
 	if (selects !== null) {
 		selects.addEventListener('change', function () {
-			var defaults = ['github', 'bitbucket', 'gitlab', 'gitea', 'zipfile'];
+			let defaults = ['github', 'bitbucket', 'gitlab', 'gitea', 'zipfile'];
 
 			// Create difference array.
-			var hideMe = remove(defaults, this.value);
+			let hideMe = remove(defaults, this.value);
 
 			// Hide items with unselected api's classes.
 			hideMe.forEach(function (item) {
-				var parents = getParents(item, 'tr');
+				let parents = getParents(item, 'tr');
 				displayNone(parents);
 			});
 
 			// Show selected setting.
 			[this.value].forEach(function (item) {
-				var parents = getParents(item, 'tr');
+				let parents = getParents(item, 'tr');
 				display(parents);
 			});
 		});
@@ -73,7 +73,7 @@
 
 	// Vanilla JS version of jQuery `$(query).parents(selector)`.
 	function vanillaParents(element, selector) {
-		var parents = [];
+		let parents = [];
 		if (NodeList.prototype.isPrototypeOf(element)) {
 			element.forEach((item) => {
 				element = item.parentElement.closest(selector);