only load Install and Remote Management from settings pages

CHANGES.md

@@ -8,6 +8,7 @@
 * add `override` query arg for RESTful updates to specific tags
 * refactor to remove redundancy between rollback and branch switch
 * fixed incorrect update notification after update
+* fixed to only load `Settings` on appropriate pages
 
 #### 8.2.1 / 2018-07-22
 * fixed setting of `Requires PHP` header in `API::set_readme_info()`

github-updater.php

@@ -12,7 +12,7 @@
  * Plugin Name:       GitHub Updater
  * Plugin URI:        https://github.com/afragen/github-updater
  * Description:       A plugin to automatically update GitHub, Bitbucket, GitLab, or Gitea hosted plugins, themes, and language packs. It also allows for remote installation of plugins or themes into WordPress.
- * Version:           8.2.1.5
+ * Version:           8.2.1.6
  * Author:            Andy Fragen
  * License:           GNU General Public License v2
  * License URI:       http://www.gnu.org/licenses/gpl-2.0.html

src/GitHub_Updater/Settings.php

@@ -77,8 +77,10 @@ public function run() {
 		$this->load_hooks();
 
 		// Need to ensure these classes are activated here for hooks to fire.
-		Singleton::get_instance( 'Install', $this )->run();
-		Singleton::get_instance( 'Remote_Management', $this );
+		if ( $this->is_current_page( [ 'options-general.php', 'settings.php' ] ) ) {
+			Singleton::get_instance( 'Install', $this )->run();
+			Singleton::get_instance( 'Remote_Management', $this );
+		}
 	}
 
 	/**
@@ -87,15 +89,18 @@ public function run() {
 	protected function load_hooks() {
 		add_action( is_multisite() ? 'network_admin_menu' : 'admin_menu', [ $this, 'add_plugin_page' ] );
 		add_action( 'network_admin_edit_github-updater', [ $this, 'update_settings' ] );
-		add_action( 'admin_init', [ $this, 'update_settings' ] );
-		add_action( 'admin_init', [ $this, 'page_init' ] );
 
 		add_filter(
 			is_multisite()
 			? 'network_admin_plugin_action_links_' . $this->ghu_plugin_name
 			: 'plugin_action_links_' . $this->ghu_plugin_name,
 			[ $this, 'plugin_action_links' ]
 		);
+
+		if ( $this->is_current_page( [ 'options.php', 'options-general.php', 'settings.php' ] ) ) {
+			add_action( 'admin_init', [ $this, 'update_settings' ] );
+			add_action( 'admin_init', [ $this, 'page_init' ] );
+		}
 	}
 
 	/**

src/GitHub_Updater/Traits/GHU_Trait.php

@@ -51,6 +51,17 @@ public function load_options() {
 		$base::$options = get_site_option( 'github_updater', [] );
 	}
 
+	/**
+	 * Check current page.
+	 *
+	 * @param array $pages
+	 * @return bool
+	 */
+	public function is_current_page( array $pages ) {
+		global $pagenow;
+		return in_array( $pagenow, $pages );
+	}
+
 	/**
 	 * Returns repo cached data.
 	 *