Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the in-progress icon float layer out #183

Open
marslo opened this issue Mar 23, 2021 · 15 comments
Open

the in-progress icon float layer out #183

marslo opened this issue Mar 23, 2021 · 15 comments

Comments

@marslo
Copy link

marslo commented Mar 23, 2021

Jenkins version: 2.284/2.283
simple theme plugin version: 0.6
material theme: 0.3.2

The running icon shows up:

after using Jenkins default theme:

@starwarsfan
Copy link

Second that, same here.

@Smasherr
Copy link

@starwarsfan I thought it was a feature 🤣

@mit4ever
Copy link

Metoo, maybe problem is jenkins

@marslo
Copy link
Author

marslo commented Mar 25, 2021

Metoo, maybe problem is jenkins

Jenkins default theme works well with the "in progress" status icon. So that quite unlikely is the issue of Jenkins.

@mit4ever
Copy link

Metoo, có thể vấn đề là jenkins

Chủ đề mặc định của Jenkins hoạt động tốt với biểu tượng đang chạy. Vì vậy, điều đó khá khó xảy ra là vấn đề của Jenkins.

I agree. Used to be fine but when I recently updated jenkins there was a problem with icon

@marslo
Copy link
Author

marslo commented Mar 25, 2021

well... I've using workaround bypass the issue :

svg[class*=anime] { visibility: collapse }

btw, using hidden as the same as the collapse.

Details:

it can be setup in Jenkins via:
simple-theme-7

@Smasherr
Copy link

Nice job @marslo! Would be cool to see a PR for this

@marslo
Copy link
Author

marslo commented Mar 25, 2021

Nice job @marslo! Would be cool to see a PR for this

this is actually the workaround, just hidden the overlayer svg image...

@marslo marslo changed the title the running icon float layer out the in-progress icon float layer out Mar 25, 2021
@fguillotpro
Copy link

fguillotpro commented May 17, 2021

Still happening with Jenkins 2.293 and jenkins-material-theme.css v.1.3.3, any news on that matter? Thanks

@eplodn
Copy link

eplodn commented Jun 8, 2021

Implemented the workaround (thanks @marslo !) but it would be great if @afonsof or somebody could fix the underlying issue.

@offa
Copy link

offa commented Jun 15, 2021

Related Jenkins Issue: JENKINS-65808

@offa
Copy link

offa commented Jun 15, 2021

The issue has hit other themes too: TobiX/jenkins-neo2-theme#40

@pboiseau
Copy link

Hello, thank you for the workaround.

If anyone want to set up it using groovy script, here is the script I use

import jenkins.model.Jenkins
import org.jenkinsci.plugins.simpletheme.CssUrlThemeElement
import org.jenkinsci.plugins.simpletheme.CssTextThemeElement

Jenkins jenkins = Jenkins.get()

def themeDecorator = jenkins.getExtensionList(org.codefirst.SimpleThemeDecorator.class).first()

themeDecorator.setElements([
        new CssUrlThemeElement('https://cdn.rawgit.com/afonsof/jenkins-material-theme/gh-pages/dist/material-indigo.css'),
        // fix jenkins theme issue https://github.com/afonsof/jenkins-material-theme/issues/183#issuecomment-806518351
        new CssTextThemeElement('svg[class*=anime] { visibility: collapse }')
])

jenkins.save()

@abstract-entity
Copy link

well... I've using workaround bypass the issue :

svg[class*=anime] { visibility: collapse }

btw, using hidden as the same as the collapse.

Details:

it can be setup in Jenkins via: simple-theme-7

Thanks, it do the job

@jiuhuche120
Copy link

ths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants