Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify a custom cache directory #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nksaunders
Copy link
Collaborator

It would be useful to be able to specify a custom directory for the downloaded TESScut fits files. This PR adds a keyword argument to Source to input a custom cache directory.

To do before merging:

  • disambiguate download_dir and fn_dir, and make sure they don't confict
  • make sure TargetData knows about the right cache directory for the input Source data

@nksaunders nksaunders changed the title [WIP] Allow users to specify a custom cache directory Allow users to specify a custom cache directory Nov 22, 2019
@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #135 into master will increase coverage by 0.04%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   45.08%   45.12%   +0.04%     
==========================================
  Files          18       18              
  Lines        1719     1724       +5     
==========================================
+ Hits          775      778       +3     
- Misses        944      946       +2
Impacted Files Coverage Δ
eleanor/source.py 53.46% <78.26%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 824f8fc...786e787. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant