conditionally required field, requiredWhen validator spec #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What a timing. I need this :D Thank you @NewBieCoderXD. |
|
Thanks for the PR, this looks promising! I'll need to refresh myself with the history on this feature request and do a review, will try and get to that in the next couple days |
af
reviewed
Aug 9, 2024
example/server.js
Outdated
| const server = (env.USE_TLS)? http.createServer(serverBody): https.createServer({ | ||
| key: fs.readFileSync(env.TLS_KEY_PATH), | ||
| cert: fs.readFileSync(env.TLS_CERT_PATH) | ||
| },serverBody); |
There was a problem hiding this comment.
Could you roll back the changes to this example file? IMO they make this very simple file harder to follow
|
Sorry for the slow response, this one got away from me! I have a couple things to address but will push them in a separate commit. Thanks for the contribution! |
|
Hi @af, Now that this PR has been merged. Will it go out in an 8.1 release? I'm really keen to use this new feature. Thanks to both yourself and of course @NewBieCoderXD for getting this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heavily inspired by @neezer, #78, and #81
How it works:
instead of validate requirement based on raw env, we clean the env, then check if it is required.
requiredWhen is a boolean function that takes cleaned env then returns if the field is required.
I think this would get rid of most of the problems by using cleaned env instead of raw.
let me know what you think :)
(this is actually my first few PR outside of university, so I'm sorry if I've done anything wrong)